Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-129643 / 24.10 / Pool tint in new enclosure #10301

Merged
merged 3 commits into from
Jul 10, 2024
Merged

NAS-129643 / 24.10 / Pool tint in new enclosure #10301

merged 3 commits into from
Jul 10, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jul 9, 2024

Mocking utility will now create multiple pools and vdevs.
Pools should be correctly colored on both rackmount and mini enclosures.

Note: colors may change in the future.

@undsoft undsoft requested a review from a team as a code owner July 9, 2024 11:16
@undsoft undsoft requested review from RehanY147 and removed request for a team July 9, 2024 11:16
@bugclerk bugclerk changed the title NAS-129643: Pool tint in new enclosure NAS-129643 / 24.10 / Pool tint in new enclosure Jul 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 9, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129643

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 37.93103% with 72 lines in your changes missing coverage. Please review.

Project coverage is 76.59%. Comparing base (ce378ce) to head (9f9eb68).
Report is 4 commits behind head on master.

Files Patch % Lines
...-enclosure/enclosure-templates/utils/pool.utils.ts 0.00% 27 Missing ⚠️
...pages/system/enclosure/services/enclosure.store.ts 11.53% 23 Missing ⚠️
...re-page/enclosure-view/enclosure-view.component.ts 6.25% 15 Missing ⚠️
...-enclosure/enclosure-templates/utils/disk.utils.ts 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10301      +/-   ##
==========================================
+ Coverage   76.57%   76.59%   +0.01%     
==========================================
  Files        1587     1590       +3     
  Lines       54718    54783      +65     
  Branches     6470     6477       +7     
==========================================
+ Hits        41903    41960      +57     
- Misses      12815    12823       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RehanY147
RehanY147 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When choosing how many vdevs and pools should be added, the text should be fixed.

@undsoft undsoft enabled auto-merge (squash) July 10, 2024 12:16
@undsoft undsoft disabled auto-merge July 10, 2024 12:52
@undsoft undsoft merged commit c9854bc into master Jul 10, 2024
9 of 10 checks passed
@undsoft undsoft deleted the NAS-129643 branch July 10, 2024 12:52
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-129643 is targeted to the following versions which have not received their corresponding PRs: 24.04-BETA.1

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RehanY147 RehanY147 RehanY147 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@undsoft @bugclerk @RehanY147